Re: installdir patch for win32 - Mailing list pgsql-patches

From Claudio Natoli
Subject Re: installdir patch for win32
Date
Msg-id A02DEC4D1073D611BAE8525405FCCE2B55F3B9@harris.memetrics.local
Whole thread Raw
In response to installdir patch for win32  (Claudio Natoli <claudio.natoli@memetrics.com>)
Responses Re: installdir patch for win32
List pgsql-patches
Tom Lane wrote:
> If the problem is that we need PKGLIBDIR not to be frozen at compile
> time, then let's fix the problem for everybody, not add a pile of
> undocumented #ifdef WIN32 hacks.  (And it is a problem for everybody;

Happy to go with whatever you can suggest. However, will point out that this
patch is refactoring for general use code which had already accepted and in
the source base, and for which opinions had already been previously
canvassed.


> Every "#ifdef WIN32" I see reduces my opinion of the quality of work
> being done for this port.

At risk of getting (further? :-) on your bad side, IMHO that is a specious
metric.

Cheers,
Claudio

---
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>

pgsql-patches by date:

Previous
From: Claudio Natoli
Date:
Subject: Re: APC/socket fix (final?)
Next
From: Tom Lane
Date:
Subject: Re: APC/socket fix (final?)