Pre-1970 dates under Win32 - Mailing list pgsql-hackers

From Claudio Natoli
Subject Pre-1970 dates under Win32
Date
Msg-id A02DEC4D1073D611BAE8525405FCCE2B55F2BA@harris.memetrics.local
Whole thread Raw
Responses Re: Pre-1970 dates under Win32  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Under Win32, localtime returns NULL for dates pre 1970.

A number of places in the code fail to check from a NULL return from
localtime, with none seemingly more problematic than those calls within
DetermineLocalTimeZone, which causes SEGVs in a number of tests (which
clearly pass pre 1970 dates to this function).

If we want to support pre-1970 dates, which I imagine we do, then this
function requires some serious rework under Win32. If we don't, then I'm
guessing we can just drop in some error checking for a NULL return from
localtime (as I've done on my personal source base), and modify the tests
for Win32 accordingly.

Comments?

Cheers,
Claudio
---
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>

pgsql-hackers by date:

Previous
From: Christopher Kings-Lynne
Date:
Subject: Re: Idea about better configuration options for sort memory
Next
From: Tom Lane
Date:
Subject: Re: Pre-1970 dates under Win32