Re: PATCH: Exclude additional directories in pg_basebackup - Mailing list pgsql-hackers

From David Steele
Subject Re: PATCH: Exclude additional directories in pg_basebackup
Date
Msg-id 9f249d91-08cb-00eb-f394-221b19e9a0f6@pgmasters.net
Whole thread Raw
In response to Re: PATCH: Exclude additional directories in pg_basebackup  (David Steele <david@pgmasters.net>)
List pgsql-hackers
On 9/7/16 8:21 AM, David Steele wrote:
> On 9/6/16 10:25 PM, Michael Paquier wrote:
>> I find that ugly. I'd rather use an array with undefined size for the
>> fixed elements finishing by NULL, remove EXCLUDE_DIR_MAX and
>> EXCLUDE_DIR_STAT_TMP and use a small routine to do the work done on
>> _tarWriteHeader...
> 
> My goal was to be able to fully reuse the code that creates the paths,
> but this could also be done by following your suggestion and also moving
> the path code into a function.

I just realized all I did was repeat what you said...

-- 
-David
david@pgmasters.net



pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: PATCH: Exclude additional directories in pg_basebackup
Next
From: Kuntal Ghosh
Date:
Subject: Re: WAL consistency check facility