Re: Preventing abort() and exit() calls in libpq - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Preventing abort() and exit() calls in libpq
Date
Msg-id 9d35a4ac-2c75-cb44-95ab-61d69deb072e@enterprisedb.com
Whole thread Raw
In response to Re: Preventing abort() and exit() calls in libpq  (Jacob Champion <pchampion@vmware.com>)
Responses Re: Preventing abort() and exit() calls in libpq  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 01.07.21 00:41, Jacob Champion wrote:
> On Wed, 2021-06-30 at 18:29 -0400, Tom Lane wrote:
>> I wrote:
>>> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>>>> Could we set this rule up a little bit differently so that it is only
>>>> run when the library is built.
>>>> Right now, make world on a built tree makes 17 calls to this "nm" line,
>>>> and make check-world calls it 81 times.  I think once would be enough. ;-)
>>> Hmm, didn't realize that would happen.  Will see what can be done.
>>
>> Looks like we'd have to make use of a dummy stamp-file, more or less
>> as attached.  Any objections?
> 
> Spitballing -- if you don't like the stamp file, you could add the
> check to the end of the $(shlib) rule, surrounded by an ifeq check.
> Then .DELETE_ON_ERROR should take care of the rest, I think.

Somewhere in the $(shlib) rule would seem most appropriate.  But I don't 
understand the rest: What ifeq, and why .DELETE_ON_ERROR?



pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: Remove unused code from the KnownAssignedTransactionIdes submodule
Next
From: Tom Lane
Date:
Subject: Re: Preventing abort() and exit() calls in libpq