Re: Remove Item type - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Remove Item type
Date
Msg-id 9c32376b-4c6c-4410-ac28-840480b0a29b@eisentraut.org
Whole thread Raw
In response to Re: Remove Item type  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
On 24.10.25 17:32, Nathan Bossart wrote:
> On Mon, Sep 29, 2025 at 12:20:00PM +0200, Peter Eisentraut wrote:
>> So I'm proposing to remove the Item type, replace it with void * in
>> function prototypes, and remove all the casts.
> 
> The general idea seems reasonable to me, but I'm a little concerned that
> using "void *" could break extensions written in C++ (see commit d5ca15e).
> I haven't confirmed there's an actual issue here, though.

Thanks for checking.  This is not a problem, because what C++ disallows 
is implicit conversion from void * to another pointer type, but it does 
allow it the other way around, which is what would be happening here.

I have committed this.




pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Suggestion to add --continue-client-on-abort option to pgbench
Next
From: Japin Li
Date:
Subject: Re: Improve pg_sync_replication_slots() to wait for primary to advance