Re: doc: modify the comment in function libpqrcv_check_conninfo() - Mailing list pgsql-hackers

From ikedarintarof
Subject Re: doc: modify the comment in function libpqrcv_check_conninfo()
Date
Msg-id 9c15a4b74d09348d03b02934fc429c94@oss.nttdata.com
Whole thread Raw
In response to Re: doc: modify the comment in function libpqrcv_check_conninfo()  (Jelte Fennema-Nio <postgres@jeltef.nl>)
Responses Re: doc: modify the comment in function libpqrcv_check_conninfo()
List pgsql-hackers
Thank you for your comment!

I've added the must_use_password argument. A new patch is attached.


On 2024-06-26 23:36, Jelte Fennema-Nio wrote:
> On Wed, 26 Jun 2024 at 14:53, ikedarintarof
> <ikedarintarof@oss.nttdata.com> wrote:
>> The function 'libpqrcv_check_conninfo()' returns 'void', but the 
>> comment
>> above says that the function returns true or false.
>> I've attached a patch to modify the comment.
> 
> Agreed that the current comment is wrong, but the new comment should
> mention the must_use_password argument. Because only if
> must_use_password is true, will it throw an error.

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: CI, macports, darwin version problems
Next
From: Simone Giusso
Date:
Subject: ClientRead on ROLLABACK