Re: [COMMITTERS] pgsql: Add function to import operating systemcollations - Mailing list pgsql-committers

From Peter Eisentraut
Subject Re: [COMMITTERS] pgsql: Add function to import operating systemcollations
Date
Msg-id 9b99c8c5-5a77-f1ae-6d90-bef0e85552a0@2ndquadrant.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add function to import operating system collations  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [COMMITTERS] pgsql: Add function to import operating systemcollations
Re: [COMMITTERS] pgsql: Add function to import operating system collations
List pgsql-committers
On 1/18/17 10:43 AM, Tom Lane wrote:
> Maybe an appropriate fix would be to ignore collations whose names aren't
> equal to what we get for collcollate/collctype.  Presumably the latter
> are getting canonicalized somehow.

Yeah, it's supposed to do that.  Note that the second call to
CollationCreate() in pg_import_system_collations() has the "if not
exists" argument true regardless.  So the error appears to come from the
first one.

What's fishy about this is that I can't reproduce it locally in a
variety of VMs, and the buildfarm is not unanimous either.


--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-committers by date:

Previous
From: Euler Taveira
Date:
Subject: Re: [COMMITTERS] pgsql: Add function to import operating systemcollations
Next
From: Peter Eisentraut
Date:
Subject: Re: [COMMITTERS] pgsql: Add function to import operating systemcollations