Re: Make EXPLAIN generate a generic plan for a parameterized query - Mailing list pgsql-hackers

From Laurenz Albe
Subject Re: Make EXPLAIN generate a generic plan for a parameterized query
Date
Msg-id 9b8512cf5ed3872a4962938e79141d33d501c8d6.camel@cybertec.at
Whole thread Raw
In response to Re: Make EXPLAIN generate a generic plan for a parameterized query  (Michel Pelletier <pelletier.michel@gmail.com>)
Responses Re: Make EXPLAIN generate a generic plan for a parameterized query
Re: Make EXPLAIN generate a generic plan for a parameterized query
List pgsql-hackers
On Tue, 2022-12-27 at 14:37 -0800, Michel Pelletier wrote:
> I built and tested this patch for review and it works well, although I got the following warning when building:
>
> analyze.c: In function 'transformStmt':
> analyze.c:2919:35: warning: 'generic_plan' may be used uninitialized in this function [-Wmaybe-uninitialized]
>  2919 |         pstate->p_generic_explain = generic_plan;
>       |         ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
> analyze.c:2909:25: note: 'generic_plan' was declared here
>  2909 |         bool            generic_plan;
>       |                         ^~~~~~~~~~~~

Thanks for checking.  The variable should indeed be initialized, although
my compiler didn't complain.

Attached is a fixed version.

Yours,
Laurenz Albe

Attachment

pgsql-hackers by date:

Previous
From: Vik Fearing
Date:
Subject: Re: MERGE ... RETURNING
Next
From: Matthias van de Meent
Date:
Subject: Re: BUG: Postgres 14 + vacuum_defer_cleanup_age + FOR UPDATE + UPDATE