Re: suggested warning about perl nested named subroutines - Mailing list pgsql-patches

From Greg Sabino Mullane
Subject Re: suggested warning about perl nested named subroutines
Date
Msg-id 9a9a8e6128e6dc6c156b9c4745b71241@biglumber.com
Whole thread Raw
In response to Re: suggested warning about perl nested named subroutines  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-patches
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


>>One more annoyance, while I'm here: what's with "spi_exec_query()"? Is that
>>the best name we could come up with? How about something short and simple,
>>in the same vein as "elog()", such as "sql()" ? :)

> I don't much like it either. But it's there from 8.0, so we really
> shouldn't change it now. OTOH I don't like also having spi_query, but
> nobody has kicked up much. If we're going to change that we need to
> change it real fast.

We don't need to change it and break backwards-compatibilty, but we could
easily add in a synonym and deprecate spi_*. I prefer sql() or exec(),
although the latter is a little to close to "EXECUTE". Maybe do() in
the spirit of DBI (although it returns result sets, so that could be
potentially confusing). Other ideas? I'm assuming this is a 8.2 thing,
so we have plenty of time. :)

- --
Greg Sabino Mullane greg@turnstep.com
PGP Key: 0x14964AC8 200510231734
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8

-----BEGIN PGP SIGNATURE-----

iD8DBQFDXAJBvJuQZxSWSsgRAs5qAJ9xcw/lcEcOsD3gBcc6o6xQcC4HTgCeNhKQ
aofyqUREbX0jYJD+CVY3FQI=
=1XDK
-----END PGP SIGNATURE-----



pgsql-patches by date:

Previous
From: Martijn van Oosterhout
Date:
Subject: [PATCH] Fix Ctrl-C related issues in psql (not for 8.1)
Next
From: "Greg Sabino Mullane"
Date:
Subject: Another small pl/perl patch