Re: The pgperltidy diffs in HEAD - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: The pgperltidy diffs in HEAD
Date
Msg-id 9a1d41f3-5ea5-42c3-9235-6e94448f95a8@dunslane.net
Whole thread Raw
In response to Re: The pgperltidy diffs in HEAD  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: The pgperltidy diffs in HEAD
List pgsql-hackers
On 2025-11-25 Tu 2:36 PM, Daniel Gustafsson wrote:
>> On 25 Nov 2025, at 20:31, Álvaro Herrera <alvherre@kurilemu.de> wrote:
>>
>> On 2025-Nov-25, Daniel Gustafsson wrote:
>>
>>> Agreed. Perhaps something like the attached would work?
>> Hmm, I got this
>>
>> src/tools/pgindent/pgperltidy: 10: [: 0: unexpected operator
>>
>> $ ls -l /bin/sh
>> lrwxrwxrwx 1 root root 4 feb  4  2025 /bin/sh -> dash*
>>
>> (Seems to work ok silently with bash.)
> If you replace the if statement with the one below using test, does that make
> it work?
>
>     if test $? = 1; then
>

Looks to me like your original patch had == where it should have had =

Your formulation above corrects that.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent
Next
From: Nathan Bossart
Date:
Subject: Re: pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent