Re: Separators in pg_hosts.conf fields - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Separators in pg_hosts.conf fields
Date
Msg-id 9E767D01-08A1-4DF1-8122-B11AD932C8BA@yesql.se
Whole thread
In response to Separators in pg_hosts.conf fields  (Noah Misch <noah@leadboat.com>)
Responses Re: Separators in pg_hosts.conf fields
List pgsql-hackers
> On 26 Apr 2026, at 23:32, Noah Misch <noah@leadboat.com> wrote:
>
> If the build directory name contains a comma,
> src/test/modules/ssl_passphrase_callback fails on master since commit 4f43302.
> It fails because hba.c:next_token() treats a comma as a token separator:

Ugh, thanks for reporting.

> * Tokens can be delimited by double quotes (this allows the inclusion of
> * commas, blanks, and '#', but not newlines).  As in SQL, write two
> * double-quotes to represent a double quote.
>
> Commit 4f43302 documented the pg_hosts.conf hostname field as a
> comma-separated list, but not the other fields.  Should other pg_hosts.conf
> fields continue to require quoting around commas, or not?

Yes, only the hostname field is a comma-separated list.  I think this should be
added to the documentation as well on top of the test fix in your patch.  Do
you want me to take care of both parts?

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Separators in pg_hosts.conf fields
Next
From: Noah Misch
Date:
Subject: Re: Separators in pg_hosts.conf fields