Re: amcheck: support for GiST - Mailing list pgsql-hackers

From Roman Khapov
Subject Re: amcheck: support for GiST
Date
Msg-id 9C2BD9F9-0D75-473C-B965-BE68FCB8EF41@yandex-team.ru
Whole thread Raw
In response to Re: amcheck: support for GiST  (Japin Li <japinli@hotmail.com>)
Responses Re: amcheck: support for GiST
List pgsql-hackers
Hi!
Thanks for your review!

We discussed offline about the patch, and I decided to make a review of it and fixes
up to your comments.


>
> v2026-01-10-0001
> ================
>
> 1.
> I'm pretty sure access/heaptoast.h is not needed by verify_nbtree.c.
>

In fact this include is necessary because of line verify_common.c:236 which
uses TOAST_INDEX_TARGET


>
> v2026-01-10-0002
> ================
>
> blockNo is unsigned integer, so we should use %u in the format string.
>
> The same goes for parentblkno — it should also use %u.
>

Yes seems like there was misusage of format symbol.. I attached the v2026-01-12 with
fixed symbol. Thanks!

--
Best regards,
Roman Khapov




Attachment

pgsql-hackers by date:

Previous
From: Michael Banck
Date:
Subject: Re: Maybe BF "timedout" failures are the client script's fault?
Next
From: "Jonathan Gonzalez V."
Date:
Subject: Re: Make PGOAUTHCAFILE in libpq-oauth work out of debug mode