Re: Reworks of CustomScan serialization/deserialization - Mailing list pgsql-hackers

From Kouhei Kaigai
Subject Re: Reworks of CustomScan serialization/deserialization
Date
Msg-id 9A28C8860F777E439AA12E8AEA7694F8011D30F4@BPXM15GP.gisp.nec.co.jp
Whole thread Raw
In response to Re: Reworks of CustomScan serialization/deserialization  (Petr Jelinek <petr@2ndquadrant.com>)
Responses Re: Reworks of CustomScan serialization/deserialization
List pgsql-hackers
> >> On 15/03/16 05:03, Kouhei Kaigai wrote:
> >>> Petr,
> >>>
> >>> The attached patch is the revised one that follows the new extensible-
> >>> node routine.
> >>>
> >>> It is almost same the previous version except for:
> >>> - custom-apis.[ch] was renamed to custom-node.[ch]
> >>> - check for the length of custom-scan-method name followed
> >>>     the manner of RegisterExtensibleNodeMethods()
> >>>
> >>
> >> Hi,
> >>
> >> looks good, only nitpick I have is that it probably should be
> >> custom_node.h with underscore given that we use underscore everywhere
> >> (except for libpq and for some reason atomic ops).
> >>
> > Sorry for my response late.
> >
> > The attached patch just renamed custom-node.[ch] by custom_node.[ch].
> > Other portions are not changed from the previous revison.
> >
> 
> Forgot to attach?
>
Yes.... Thanks,
--
NEC Business Creation Division / PG-Strom Project
KaiGai Kohei <kaigai@ak.jp.nec.com>


Attachment

pgsql-hackers by date:

Previous
From: Petr Jelinek
Date:
Subject: Re: VS 2015 support in src/tools/msvc
Next
From: Michael Paquier
Date:
Subject: Re: VS 2015 support in src/tools/msvc