Re: pgsql: Add tests for reinit.c - Mailing list pgsql-committers

From David Steele
Subject Re: pgsql: Add tests for reinit.c
Date
Msg-id 998b0442-d17c-47bf-0e92-5956d3f45448@pgmasters.net
Whole thread Raw
In response to Re: pgsql: Add tests for reinit.c  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Add tests for reinit.c
List pgsql-committers
On 3/19/18 4:15 AM, Andrew Dunstan wrote:
> 
> The attached fixes it. We should probably put the function or something
> like it in TestLib.pm, though. The call to pwd is quite tricky - it
> needs to be done pretty much exactly like this, not quite sure why, but
> direct calls to "pwd -W" via system() or backticks don't work, only this
> indirect call works on jacana.

Thanks for the patch, Andrew!

Peter, would you like me to provide a patch that moves this function to
TestLib.pm?  Happy to do it, just don't want patches crossing in the
night, as it were.

Thanks,
-- 
-David
david@pgmasters.net


pgsql-committers by date:

Previous
From: Magnus Hagander
Date:
Subject: pgsql: Fix typo in comment
Next
From: Robert Haas
Date:
Subject: pgsql: Rewrite recurse_union_children to iterate, rather than recurse.