Re: Verbosity of column definition mismatch error - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Verbosity of column definition mismatch error
Date
Msg-id 9922.1105400563@sss.pgh.pa.us
Whole thread Raw
In response to Verbosity of column definition mismatch error  (Brendan Jurd <blakjak@blakjak.sytes.net>)
Responses Re: Verbosity of column definition mismatch error
List pgsql-hackers
Brendan Jurd <blakjak@blakjak.sytes.net> writes:
> ERROR:  query-specified return row and actual function return row do not 
> match

> With that in mind, I'd like to submit a request, that the verbosity of 
> this error message be increased to explain which ordinal column position 
> the error occurred at, and, if possible, the details of the mismatch.  

This is a fairly trivial change, but unfortunately it's too late for
8.0, because we froze error message texts some time ago (for the benefit
of translators).

If you want to start working on a patch for 8.1, look in 
src/backend/executor/nodeFunctionscan.c.  I'd be inclined to forget the
bool return convention for tupledesc_match() and just have it ereport
directly when it sees a problem.  The rowtype matching code in
check_sql_fn_retval (in src/backend/executor/functions.c) would be
useful as a reference.
        regards, tom lane


pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Returning multiple rowsets from a function
Next
From: Brendan Jurd
Date:
Subject: Re: Verbosity of column definition mismatch error