Re: patches for jdbc1 (fwd) - Mailing list pgsql-jdbc

From Peter T Mount
Subject Re: patches for jdbc1 (fwd)
Date
Msg-id 985270638.3aba096e8fde5@webmail.retep.org.uk
Whole thread Raw
In response to patches for jdbc1 (fwd)  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-jdbc
Quoting Peter Eisentraut <peter_e@gmx.net>:

> Peter M., can you examine this patch?

Hmmm, looks ok although I'm not sure by reading this if the warning target gets
executed if jdk1.2+ is not set, because of the if="jdk1.2+" in the compile
target.

I'll have to try it with ant, but I think ant may skip the depends list if the
if fails (which I think it should do).

> Index: src/interfaces/jdbc/org/postgresql/jdbc1/ResultSet.java

This lot's ok. I couldn't fix much on the JDBC1.2 driver because not having
jdk1.1.8 is a slight problem :)

> Index: src/interfaces/jdbc/org/postgresql/jdbc1/Statement.java
> ===================================================================

This one is ok also (same reason above).

Peter

--
Peter Mount peter@retep.org.uk
PostgreSQL JDBC Driver: http://www.retep.org.uk/postgres/
RetepPDF PDF library for Java: http://www.retep.org.uk/pdf/

pgsql-jdbc by date:

Previous
From: Chris Czeyka
Date:
Subject: Lost in unicode?
Next
From: Peter T Mount
Date:
Subject: Re: I can't connect