Re: get rid of Pointer type, mostly - Mailing list pgsql-hackers

From Tom Lane
Subject Re: get rid of Pointer type, mostly
Date
Msg-id 985179.1764011713@sss.pgh.pa.us
Whole thread Raw
In response to Re: get rid of Pointer type, mostly  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: get rid of Pointer type, mostly
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Nov 24, 2025 at 1:46 PM David Geier <geidav.pg@gmail.com> wrote:
>> The GIN code makes use of pointer but src/backend/access/gin only has 29
>> occurrences. If you like I can help out fixing up the GIN code and share
>> a page here. Let me know.

> I'd go for it! I mean, who knows whether your patch will be accepted?
> But another pair of eyes couldn't hurt. It seems like we all agree
> that a full removal of Pointer would be better than a partial removal;
> it's just a question of whether we can get there without too much
> other awkwardness.

If there are actually places in GIN where using void* would be less
readable than using Pointer, that would certainly be interesting
information.  Perhaps the patch would need to spend some effort
on adding comments, not just mechanically replacing the typedef?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: get rid of Pointer type, mostly
Next
From: Masahiko Sawada
Date:
Subject: Re: Assertion failure in SnapBuildInitialSnapshot()