Re: Win64 warnings about size_t - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Win64 warnings about size_t
Date
Msg-id 9837222c1001011150m4c9932a7n550124e6ff5c2f15@mail.gmail.com
Whole thread Raw
In response to Re: Win64 warnings about size_t  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Jan 1, 2010 at 20:33, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> On Fri, Jan 1, 2010 at 20:12, Peter Eisentraut <peter_e@gmx.net> wrote:
>>> This shouldn't be a problem for the same reason that casting size_t to
>>> int is not a problem in the PostgreSQL backend code, but perhaps writing
>>> 1L << ... would fix it.
>
>> 1L didn't fix it. 1LL did, however.
>
> ... and would break things on many many other platforms.

That's what I was afraid of.


> Use "(Size) 1" instead of "1" if you really want to suppress this.

That fixes it as well. Will apply a patch to that effect.


-- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [PATCH] Windows x64 [repost]
Next
From: Peter Eisentraut
Date:
Subject: Re: IntArray in c.h