On Sat, Dec 12, 2009 at 12:24, Magnus Hagander <magnus@hagander.net> wrote:
> On Sat, Dec 12, 2009 at 02:41, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Sun, Dec 6, 2009 at 11:29 PM, Greg Smith <greg@2ndquadrant.com> wrote:
>>> Magnus Hagander wrote:
>>>
>>> On Sun, Nov 29, 2009 at 13:05, Magnus Hagander <magnus@hagander.net> wrote:
>>>
>>>
>>> I'll be happy to work on this to get it ready for commit, or do you
>>> want to do the updates?
>>>
>>>
>>> Here's a patch with my work so far. Major points missing is the
>>> sanitizing of the username and the docs.
>>>
>>>
>>> It looks like you did an initial review here already. Since we haven't
>>> heard from Robert in a while and you seem interested in the patch, I just
>>> updated this one to list you as the committer and marked it "ready for
>>> committer". You can commit it or bounce it from there, but it's obvious
>>> none of our other reviewers are going to be able to do anything with it.
>>
>> I think we should mark this returned with feedback, since it sounds
>> like there are still open items.
>
> I plan to clean up those open item smyself since there has been no
> further feedback from the OP. Hopefully in time before the CF ends. So
> please leave it for a few days more :-)
I have applied the attached, rather heavily reworked, patch. It also
includes the required documentation.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/