Re: GUC time unit spelling a bit inconsistent - Mailing list pgsql-hackers

From Tom Lane
Subject Re: GUC time unit spelling a bit inconsistent
Date
Msg-id 9821.1182184274@sss.pgh.pa.us
Whole thread Raw
In response to Re: GUC time unit spelling a bit inconsistent  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: GUC time unit spelling a bit inconsistent  (Gregory Stark <stark@enterprisedb.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> - I was bitten by this too, not long ago, and took me a while to
>   understand why.  Should we at least log a HINT or something?

Yeah, a HINT listing the allowed spellings of the unit would go a long
way here.

>   However, preffixing with M or K does not work:

It's case-sensitive.  We had that argument already, but I still think
this decision was wrong.

> - In shared_buffers, these work:
>   8MB
>   8 MB

>   These don't work:
>   8M B
>   8 M B

Looking at the code, spaces before the unit are allowed, but not spaces
within or after.  I agree with disallowing embedded spaces, I think,
but not allowing trailing spaces is inconsistent with our practice in
other cases (in particular, these very same variables, when written as
pure numbers...)
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: GUC time unit spelling a bit inconsistent
Next
From: Peter Eisentraut
Date:
Subject: Re: GUC time unit spelling a bit inconsistent