Re: Moving snapshot code around - Mailing list pgsql-patches

From Tom Lane
Subject Re: Moving snapshot code around
Date
Msg-id 980.1206555445@sss.pgh.pa.us
Whole thread Raw
In response to Re: Moving snapshot code around  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Moving snapshot code around  (Alvaro Herrera <alvherre@commandprompt.com>)
Re: Moving snapshot code around  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-patches
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Tom Lane wrote:
>> I'd have gone with snapmgr.h/c for consistency with existing filenames
>> (bufmgr, lmgr, etc).

> Doh!  Sorry.  We're at the best time for changing the name, since the
> file has no history.  Shall I?

+1

>> I don't like that very much.  What about just moving the HTSU_Result
>> enum's declaration somewhere else?  Two possibilities are heapam.h
>> itself, or the new snapshot.h file (which'd then have to be included
>> by heapam.h, but it seems lightweight enough that that's not too
>> terrible).

> Well, heapam.h includes a lot of other headers, so it doesn't look a
> good candidate to me.  I think snapshot.h is a reasonably good
> candidate.

Works for me.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Auto Partitioning Patch - WIP version 1
Next
From: Bruce Momjian
Date:
Subject: Re: Auto Partitioning Patch - WIP version 1