Postgres Pro
Downloads
Home   >   mailing lists

Re: Decoding of two-phase xacts missing from CREATE_REPLICATION_SLOT command - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: Decoding of two-phase xacts missing from CREATE_REPLICATION_SLOT command
Date
Msg-id 97a05433ccfbbdab1e3719be14272bdb790cf65a.camel@j-davis.com
Whole thread Raw
In response to Re: Decoding of two-phase xacts missing from CREATE_REPLICATION_SLOT command  (Ajin Cherian <itsajin@gmail.com>)
Responses Re: Decoding of two-phase xacts missing from CREATE_REPLICATION_SLOT command  (Ajin Cherian <itsajin@gmail.com>)
Re: Decoding of two-phase xacts missing from CREATE_REPLICATION_SLOT command  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Tree view 
On Tue, 2021-06-08 at 17:41 +1000, Ajin Cherian wrote:
> Here's an updated patchset that adds back in the option for two-phase
> in CREATE_REPLICATION_SLOT command and a second patch that adds
> support for
> two-phase decoding in pg_recvlogical.

A few things:

* I suggest putting the TWO_PHASE keyword after the LOGICAL keyword
* Document the TWO_PHASE keyword in doc/src/sgml/protocol.sgml
* Cross check that --two-phase is specified only if --create-slot is
specified
* Maybe an Assert(!(two_phase && is_physical)) in
CreateReplicationSlot()?

Other than that, it looks good, and it works as I expect it to.

Regards,
    Jeff Davis

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Make unlogged table resets detectable
Next
From: Robert Haas
Date:
Subject: Re: Race condition in recovery?