Re: A minor correction in comment in heaptuple.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: A minor correction in comment in heaptuple.c
Date
Msg-id 9788.1390686997@sss.pgh.pa.us
Whole thread Raw
In response to Re: A minor correction in comment in heaptuple.c  (Bruce Momjian <bruce@momjian.us>)
Responses Re: A minor correction in comment in heaptuple.c  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> On Sat, Jan 25, 2014 at 10:40:28PM +0100, Andres Freund wrote:
>> I think this style of pinhole copy editing is pretty pointless. There's
>> dozen checks just like this around. If somebody wants to change the rules
>> or improve comment it takes more than picking a random one.

> OK, change made.

FWIW, I don't find that an improvement either.  As Andres says, this
is just applying the same rule that's used in many other places, ie
return null if the requested attnum is off the end of the tuple.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: A better way than tweaking NTUP_PER_BUCKET
Next
From: Stephen Frost
Date:
Subject: Re: A better way than tweaking NTUP_PER_BUCKET