Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql/src/backend/utils/init (postinit.c) - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql/src/backend/utils/init (postinit.c)
Date
Msg-id 9779.976851798@sss.pgh.pa.us
Whole thread Raw
In response to pgsql/src/backend/utils/init (postinit.c)  (wieck@postgresql.org)
List pgsql-committers
Tree view 
wieck@postgresql.org writes:
> Bugfix
> Trying to connect to template0 left a global referenced buffer
> because the scan of pg_database wasn't ended properly before
> elog(FATAL).

This is a *seriously* bogus "fix".  If elog(FATAL) fails to release
buffer references, that's a problem that needs a general solution.
Trying to guarantee that we'll clean up all open scans on a retail
basis before any elog(FATAL) is obviously hopeless.

I'm a bit surprised to hear that such a bug exists anyway; I would've
thought that the elog error recovery would clean this up correctly...

            regards, tom lane

pgsql-committers by date:

Previous
From: wieck@postgresql.org
Date:
Subject: pgsql/src/backend/utils/init (postinit.c)
Next
From: tgl@postgresql.org
Date:
Subject: pgsql/src/include/commands (command.h)