Request a Demo
Home   >   mailing lists

Re: Reject invalid databases in pg_get_database_ddl() - Mailing list pgsql-hackers

From Euler Taveira
Subject Re: Reject invalid databases in pg_get_database_ddl()
Date
Msg-id 976a432b-9221-4825-8e8f-41f4375737fe@app.fastmail.com
Whole thread
In response to Re: Reject invalid databases in pg_get_database_ddl()  (Amit Langote <amitlangote09@gmail.com>)
Responses Re: Reject invalid databases in pg_get_database_ddl()
Re: Reject invalid databases in pg_get_database_ddl()
List pgsql-hackers
Tree view 
On Thu, Apr 16, 2026, at 8:46 PM, Amit Langote wrote:
>
> Thanks.  Will push the attached shortly.
>

I think the errhint() is excessive in this context. It makes sense if you are
executing ALTER DATABASE, for example. I suggest a message like

  database \"%s\" is an invalid database

Regarding the test case suggested by Japin Li, I don't think it is worth because
it is a transient state (unless something bad happened and pg_database contains
a dangling row.)


-- 
Euler Taveira
EDB   https://www.enterprisedb.com/

pgsql-hackers by date:

Previous
From: Japin Li
Date:
Subject: Re: Reject invalid databases in pg_get_database_ddl()
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: [doc] pg_ctl: fix wrong description for -l