Re: Unable parse a comment in gram.y - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Unable parse a comment in gram.y
Date
Msg-id 973933.1719161997@sss.pgh.pa.us
Whole thread Raw
In response to Re: Unable parse a comment in gram.y  ("David G. Johnston" <david.g.johnston@gmail.com>)
List pgsql-hackers
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Saturday, June 22, 2024, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
>>> Perhaps s/As func_expr/Like func_expr/ would be less confusing?

>> +1. It's easier to understand at least for me.

> +1

OK.  I looked through the rest of src/backend/parser/ and couldn't
find any other similar wording.  There's plenty of "As with ..."
and "As in ...", but at least to me those don't seem confusing.
I'll plan to push the attached after the release freeze lifts.

            regards, tom lane

diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index 4d582950b7..4a4b47ca50 100644
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -15667,7 +15667,7 @@ func_expr: func_application within_group_clause filter_clause over_clause
         ;

 /*
- * As func_expr but does not accept WINDOW functions directly
+ * Like func_expr but does not accept WINDOW functions directly
  * (but they can still be contained in arguments for functions etc).
  * Use this when window expressions are not allowed, where needed to
  * disambiguate the grammar (e.g. in CREATE INDEX).

pgsql-hackers by date:

Previous
From: Alexander Lakhin
Date:
Subject: Re: recoveryCheck/008_fsm_truncation is failing on dodo in v14- (due to slow fsync?)
Next
From: Jelte Fennema-Nio
Date:
Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel