Re: pgindent - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgindent
Date
Msg-id 9690.1302453071@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgindent  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgindent  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> On 04/10/2011 12:11 PM, Tom Lane wrote:
>> What I was a bit surprised by is the volume of changes in wparser_def.c
>> --- so far as I can see, that file hardly changed since 9.0, so why did
>> pgindent suddenly whack it around so much?  The other files that changed
>> a lot are mostly new code so widespread changes are unsurprising.

> I had a dim and possibly erroneous recollection that was one of the 
> files we excluded from pgindent runs. If you look at the history it 
> hasn't been touched by pgindent since the 8.3 run. But the changes to it 
> all look fairly kosher at first glance.

Oh, I bet you're right -- see commit
97116ca4170b974d734cea364789c389b30e6ce1.  That removed the exclusion
but I don't see any evidence that Bruce actually pgindent'd it then.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Feature request: pg_basebackup --force
Next
From: Bruce Momjian
Date:
Subject: Re: pgindent