Re: Autogenerate some wait events code and documentation - Mailing list pgsql-hackers

Hi,

On 7/9/23 9:36 AM, Michael Paquier wrote:
> On Sun, Jul 09, 2023 at 09:15:34AM +0200, Drouvot, Bertrand wrote:
>> I also noticed that you now provide the culprit line in case of parsing
>> failure (thanks for that).
> 
> Yes, that's mentioned in the commit message I quickly wrote in 0002.
> 
>>   #
>> -#   "C symbol in enums" "format in the system views" "description in the docs"
>> +#   "format in the system views" "description in the docs"
>>
>> Should we add a note here about the impact of the "format in the system views" on
>> the auto generated enum? (aka how it is generated based on its format)?
> 
> There is one, 

Yeah there is one in generate-wait_event_types.pl. I was wondering
to add one in wait_event_names.txt too (as this is the place where
no wait events would be added if any).

> but now that I look at it WAIT_EVENT repeated twice does
> not look great, so this could use "FooBarName" or equivalent:

+1 for "FooBarName"

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com