Re: [PATCH] Fix segmentation fault and infinite loop in jsonb_{plperl,plpython} - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Fix segmentation fault and infinite loop in jsonb_{plperl,plpython}
Date
Msg-id 967540.1781644216@sss.pgh.pa.us
Whole thread
In response to Re: [PATCH] Fix segmentation fault and infinite loop in jsonb_{plperl,plpython}  (Aleksander Alekseev <aleksander@tigerdata.com>)
Responses Re: [PATCH] Fix segmentation fault and infinite loop in jsonb_{plperl,plpython}
List pgsql-hackers
Aleksander Alekseev <aleksander@tigerdata.com> writes:
>> We could instead add a CHECK_FOR_INTERRUPTS, so that you can at
>> least break out of the infinite loop.  I'm not sure if the case
>> is worth more effort than that.

> Alternatively I could implement a check for the loops, if you feel
> like this is worth the effort.

I thought about that, but I'm not sure how to build a bulletproof
check at reasonable (ie, near zero) cost.  We could detect the example
case where an object refers directly to itself, by noticing that "in"
doesn't change in one iteration.  But I'm pretty sure it's possible to
build reference loops involving two or more Perl objects, and those
would fool such a check.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: [PATCH] Fix segmentation fault and infinite loop in jsonb_{plperl,plpython}
Next
From: Aleksander Alekseev
Date:
Subject: Re: [PATCH] Fix segmentation fault and infinite loop in jsonb_{plperl,plpython}