Re: Recovering from detoast-related catcache invalidations - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Recovering from detoast-related catcache invalidations
Date
Msg-id 966599.1705166312@sss.pgh.pa.us
Whole thread Raw
In response to Re: Recovering from detoast-related catcache invalidations  (Xiaoran Wang <fanfuxiaoran@gmail.com>)
Responses Re: Recovering from detoast-related catcache invalidations
List pgsql-hackers
Xiaoran Wang <fanfuxiaoran@gmail.com> writes:
> Hmm, how about first checking if any invalidated shared messages have been
> accepted, then rechecking the tuple's visibility?
> If there is no invalidated shared message accepted during
> 'toast_flatten_tuple',
> there is no need to do then visibility check, then it can save several
> CPU cycles.

Meh, I'd just as soon not add the additional dependency/risk of bugs.
This is an expensive and seldom-taken code path, so I don't think
shaving a few cycles is really important.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Konstantin Knizhnik
Date:
Subject: Re: Custom explain options
Next
From: Roberto Mello
Date:
Subject: Re: [DOC] Add detail regarding resource consumption wrt max_connections