Re: Complier warnings on mingw gcc 4.5.0 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Complier warnings on mingw gcc 4.5.0
Date
Msg-id 9654.1292440017@sss.pgh.pa.us
Whole thread Raw
In response to Re: Complier warnings on mingw gcc 4.5.0  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: Complier warnings on mingw gcc 4.5.0  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> And the attached hack allowed "make check" to succeed.

> I think the logic in tcop/postgres.c and postmaster/postmaster.c is 
> probably wrong. If we are using our getopt/getopt_long, we want to be 
> setting optreset, whether or not configure found one in the system 
> libraries.

Yeah, that's what I suggested earlier; but if your build *wasn't* using
our versions before, we're still no closer to understanding why it was
failing then.  Another small problem is that a close inspection of our
getopt.c says that it does reset "place" to point at a constant before
returning -1, in every path except the "--" case which I doubt is being
invoked.  So my idea that we were clobbering argv underneath it doesn't
seem to hold up.  I'm still feeling that we don't understand what's
happening.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Complier warnings on mingw gcc 4.5.0
Next
From: Robert Haas
Date:
Subject: Re: [PATCH] V3: Idle in transaction cancellation