Re: [PATCHES] Changes in /contrib/fulltextindex - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Changes in /contrib/fulltextindex
Date
Msg-id 9648.1025532356@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] Changes in /contrib/fulltextindex  ("Florian Helmberger" <f.helmberger@uptime.at>)
List pgsql-hackers
"Florian Helmberger" <f.helmberger@uptime.at> writes:
> Just tried your example - you're right of course! I will remove the hard
> coded delimited list and replace it with the proper calls as shown in the
> code you've sent.

Well, that was a quick hack not clean code.  Coding rules for stuff
inside the backend are- don't do setlocale; it's already been done.- explicitly cast the argument of any ctype.h macro
to (unsigned char).
 

Without the latter you have portability problems depending on whether
chars are signed or unsigned.
        regards, tom lane




pgsql-hackers by date:

Previous
From: "Florian Helmberger"
Date:
Subject: Re: [PATCHES] Changes in /contrib/fulltextindex
Next
From: Tom Lane
Date:
Subject: Re: [PATCHES] Changes in /contrib/fulltextindex