Re: pgsql: Include information on buffer usage during planning phase,in EX - Mailing list pgsql-committers

From Fujii Masao
Subject Re: pgsql: Include information on buffer usage during planning phase,in EX
Date
Msg-id 960d41f4-155e-25e1-8ddc-318c1fe0cb03@oss.nttdata.com
Whole thread Raw
In response to Re: pgsql: Include information on buffer usage during planning phase, in EX  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Include information on buffer usage during planning phase, in EX  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers

On 2020/04/04 0:34, Tom Lane wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>> Attached is the patch that changes explain.c as follows (i.e., removes
>> Buffers lines at all) to make it more stable.
> 
>>            ln := regexp_replace(ln, '\m\d+\M', 'N', 'g');
>>            -- In sort output, the above won't match units-suffixed numbers
>>            ln := regexp_replace(ln, '\m\d+kB', 'NkB', 'g');
>> -        -- Text-mode buffers output varies depending on the system state
>> -        ln := regexp_replace(ln, '^( +Buffers: shared)( hit=N)?( read=N)?', '\1 [read]');
>> +        -- Ignore text-mode buffers output because it varies depending
>> +        -- on the system state
>> +        CONTINUE WHEN (ln ~ ' +Buffers: .*');
>>            return next ln;
>>        end loop;
>>    end;
> 
> Works for me.

Many thanks! Pushed.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-committers by date:

Previous
From: Fujii Masao
Date:
Subject: pgsql: Improve stability of explain regression test.
Next
From: Robert Haas
Date:
Subject: Re: pgsql: Document color support