Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_dump should use current_database() instead of PQdb() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_dump should use current_database() instead of PQdb()
Date
Msg-id 9602.1523378978@sss.pgh.pa.us
Whole thread Raw
In response to pg_dump should use current_database() instead of PQdb()  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Tree view 
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> A report from a pgbouncer user revealed that running pg_dump -C/--create
> does not work through a connection proxy if the virtual database name on
> the proxy does not match the real database name on the database server.
> That's because pg_dump looks up the database to be dumped using the
> information from PQdb().  It should be using current_database() instead.
>  (The code was quite likely written before current_database() was
> available (PG 7.3)).

> See attached patch.

Looks reasonable in a quick once-over, but I've not tested it.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pg_dump should use current_database() instead of PQdb()
Next
From: Greg Stark
Date:
Subject: Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS