Re: pgsql: Replace pgindent shell script with Perl script. Update perltidy - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Replace pgindent shell script with Perl script. Update perltidy
Date
Msg-id 9551.1344109258@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Replace pgindent shell script with Perl script. Update perltidy  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Replace pgindent shell script with Perl script. Update perltidy
List pgsql-committers
I wrote:
> This version of pgindent is just about completely broken, so far as my
> possibly-a-bit-hoary Perl (5.8.7) is concerned.  I think it could be
> made more portable without too much effort, but I am wondering what the
> heck "\h" is supposed to mean in a regex?

After a bit of research I found that \h is a relatively recent
abbreviation for "[ \t]".  After making that substitution, and getting
rid of the rather gratuitous use of module Readonly, the script seems
to work OK in a stock Perl 5.8.7 installation.

I'm not sure if we have any project policy for minimum required Perl
version, but I've not found that any of our other Perl scripts don't
work with 5.8.  Should I commit these changes, or are you going to
tell me I need a newer Perl?  And if the latter, what is our minimum
supported version going to be?

            regards, tom lane

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Replace pgindent shell script with Perl script. Update perltidy
Next
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Replace pgindent shell script with Perl script. Update perltidy