Re: [HACKERS] ICU integration - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] ICU integration
Date
Msg-id 94ac0476-e449-4cc0-d4bd-76d39576979d@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] ICU integration  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
On 2/16/17 01:13, Peter Geoghegan wrote:
> On Wed, Feb 15, 2017 at 9:17 PM, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>> I have changed it to use ucol_nextSortKeyPart() when appropriate.
> 
> I think it would be fine if the second last argument was
> "sizeof(Datum)", not "Min(sizeof(Datum), sss->buflen2)" here:

I don't see anything that guarantees that the buffer length is always at
least sizeof(Datum).

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Anastasia Lubennikova
Date:
Subject: Re: [HACKERS] WIP: Covering + unique indexes.
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] drop support for Python 2.3