Re: BackendKeyData is mandatory? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: BackendKeyData is mandatory?
Date
Msg-id 949118.1750778077@sss.pgh.pa.us
Whole thread Raw
In response to Re: BackendKeyData is mandatory?  (Jacob Champion <jacob.champion@enterprisedb.com>)
List pgsql-hackers
Jacob Champion <jacob.champion@enterprisedb.com> writes:
> So that's
> 1) return an (empty) cancellation object even if the server has not
> sent a key, and
> 2) error out when trying to cancel with an empty object?

> That sounds reasonable to me.

+1.

> Are there any reading along who want us to continue sending an
> all-zeroes CancelRequest if the server has not sent a key?

We might have to consider doing so if evidence emerges of a server
that depends on us doing that, but right now we have no such evidence.

On the whole, reporting an error seems like a better user experience
than silently sending a cancel we know won't work.  But we have to
delay the error until a cancel is actually attempted.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: Simplify VM counters in vacuum code
Next
From: Alexander Borisov
Date:
Subject: Re: Improve the performance of Unicode Normalization Forms.