Inconsistency in installation of syscache_info.h - Mailing list pgsql-hackers

From Tom Lane
Subject Inconsistency in installation of syscache_info.h
Date
Msg-id 946828.1771185367@sss.pgh.pa.us
Whole thread Raw
Responses Re: Inconsistency in installation of syscache_info.h
List pgsql-hackers
I happened to notice that syscache_info.h is installed into
$installdir/include/server/catalog if you use a non-VPATH
autoconf build, but not if you use a VPATH build or meson.
This is not great IMO.

Just to confuse matters even more, meson builds install a copy of
src/include/catalog/README, which autoconf builds do not.

ISTM we need to get these things in sync.

You could argue that syscache_info.h could never be useful outside the
core server, but it'd be a bit painful to get the non-VPATH code to
not install it, because it just blindly installs everything matching
src/include/catalog/*.h.  So I'd vote for making the other two paths
install it too.

I've not looked into why meson is installing a copy of that
README, but it seems quite random to do so, so I'd vote for
not doing that if possible.

Thoughts?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Buffer locking is special (hints, checksums, AIO writes)
Next
From: "Greg Burd"
Date:
Subject: Re: Expanding HOT updates for expression and partial indexes