Re: [COMMITTERS] pgsql: Properly unregister OpenSSL callbacks when libpq is done with - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Properly unregister OpenSSL callbacks when libpq is done with
Date
Msg-id 946.1228769158@sss.pgh.pa.us
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Properly unregister OpenSSL callbacks when libpq is done with
List pgsql-hackers
[ still catching up on back email ]

mha@postgresql.org (Magnus Hagander) writes:
> Properly unregister OpenSSL callbacks when libpq is done with
> it's connection. This is required for applications that unload
> the libpq library (such as PHP) in which case we'd otherwise
> have pointers to these functions when they no longer exist.

I find it fairly disturbing that this patch was committed with a bug
that ensured it wouldn't even compile for the case of SSL and
THREAD_SAFETY both enabled.  Which one would think would have been
the primary case to test.  Would anyone like to reassure us why this
patch shouldn't just be reverted in toto until it's actually been
tested a bit?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Emmanuel Cecchet
Date:
Subject: Re: Transactions and temp tables
Next
From: Magnus Hagander
Date:
Subject: Re: [COMMITTERS] pgsql: Properly unregister OpenSSL callbacks when libpq is done with