Re: Set statement timeout in the query tool - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Set statement timeout in the query tool
Date
Msg-id 937d27e10912040152u35ff129di563bcf6c3d2d2fa3@mail.gmail.com
Whole thread Raw
In response to Set statement timeout in the query tool  (Guillaume Lelarge <guillaume@lelarge.info>)
Responses Re: Set statement timeout in the query tool
Re: Set statement timeout in the query tool
List pgadmin-hackers
On Fri, Dec 4, 2009 at 9:41 AM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Hi,
>
> Someone, on a french PostgreSQL forum, ask me for a statement timeout UI in
> the query tool. Here is what I've done so far:
>
>  * add a config in the Query tab of the Options window;
>  * add a textbox in the toolbar of the query tool;

We certainly don't need both.

>  * each query executed will first get the old statement_timeout value, set
>   statement_timeout to the text box one (which is initialized with the config
>   value), execute the real query, and then get back to the old value

Why save/reset it? The next query will just change it again anyway,
and there's no way round that.

> I checked the UI on Windows, Mac OS X, and Linux.

What's wrong with just setting it manually in the script anyway? There
are various parameters people might want to set, that we definitely
don't want to add UI for. I'll concede that statement_timeout is more
likely to be used than most others, but it seems to me that forcing it
to be set with every query is far less flexible than just setting it
as and when required in your script.


--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

pgadmin-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: Set statement timeout in the query tool
Next
From: Magnus Hagander
Date:
Subject: Re: Set statement timeout in the query tool