Re: pgAdmin and Slony - Mailing list pgadmin-hackers

On Thu, Sep 3, 2009 at 8:20 AM, Sachin
Srivastava<sachin.srivastava@enterprisedb.com> wrote:
> Dave,
>
> * pgAdmin code not up-to-date with latest Slony versions.
>
> Attached is a patch for updating pgAdmin code for Slony latest version.

OK, quick eyeball review:

- bool dlgRepCluster::SlonyMaximumVersion(wxString series, long minor)

should be:

bool dlgRepCluster::SlonyMaximumVersion(const wxString &series, long minor)

- Just reading the patch, it looks like we never try to load xxid*.sql
any more. That's surely wrong?


--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com