Re: PATCH: ctlSQLBox format-menu for indent/outdent, change lower/upper case & comment/uncomment for the selected text - Mailing list pgadmin-hackers

From Dave Page
Subject Re: PATCH: ctlSQLBox format-menu for indent/outdent, change lower/upper case & comment/uncomment for the selected text
Date
Msg-id 937d27e10903190912gf2b96das20a06dab50bce719@mail.gmail.com
Whole thread Raw
In response to PATCH: ctlSQLBox format-menu for indent/outdent, change lower/upper case & comment/uncomment for the selected text  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Responses Re: Re: PATCH: ctlSQLBox format-menu for indent/outdent, change lower/upper case & comment/uncomment for the selected text  (Magnus Hagander <magnus@hagander.net>)
List pgadmin-hackers
On Thu, Mar 19, 2009 at 3:50 PM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:
> Hi Team,
>
> Please find the patch for the above description.
>
> As per Dave's suggestion, I have added format submenu in the edit menu.
> Just move the code for the indent/outdent to BlockIndent function & for
> commet/uncomment to BlockComment function. And called these function from
> the event function for the format menus and from the ctlSQLBox::OnKeyDown
> function, from where it has been moved.

Thanks Ashesh.

Hackers; Ashesh worked up this patch in response to a suggestion from
Ray O'Donnell that we should add the new editing features to a menu on
the query tool to help the users learn them. I think I should have
done that in the first place, and wanted to see how invasive the patch
was, and whether we should apply it during beta.

I think it's OK. Can I get some other opinions please? Otherwise I'll
apply tomorrow.


--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: PATCH: ctlSQLBox format-menu for indent/outdent, change lower/upper case & comment/uncomment for the selected text
Next
From: Magnus Hagander
Date:
Subject: Re: Re: PATCH: ctlSQLBox format-menu for indent/outdent, change lower/upper case & comment/uncomment for the selected text