Oliver Elphick <olly@lfix.co.uk> writes:
> The GUC option log_pid is not checked; LOG_PID is used by default,
> contrary to the documentation. This patch fixes it.
No it doesn't (at least not unless you are also going to propose closing
and reopening syslog at SIGHUP to deal with changes in log_pid setting).
I'm not convinced that there's anything wrong with the code anyway.
Do you expect log_timestamp to control whether timestamps are added to
syslog entries? If so you are out of luck. Perhaps we should just
tweak the documentation to make it clearer that log_pid and
log_timestamp only control the format of non-syslog logging.
regards, tom lane
