Re: pgsql: Refactor all TAP test suites doing connection checks - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Refactor all TAP test suites doing connection checks
Date
Msg-id 933130.1617665023@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Refactor all TAP test suites doing connection checks  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Refactor all TAP test suites doing connection checks  (Michael Paquier <michael@paquier.xyz>)
List pgsql-committers
What does seem to fix it reliably is the attached.

            regards, tom lane

diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm
index bbde34c..07a9167 100644
--- a/src/test/perl/PostgresNode.pm
+++ b/src/test/perl/PostgresNode.pm
@@ -1938,7 +1938,7 @@ sub connect_fails
     # have set up things properly, and this should not block.
     my ($ret, $stdout, $stderr) = $self->psql(
         'postgres',
-        "SELECT \$\$connected with $connstr\$\$",
+        undef, # don't try to send a query
         extra_params => ['-w'],
         connstr      => "$connstr");


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks