Michael Paquier <michael@paquier.xyz> writes:
> Attached is an updated patch which does a bit more consistency work. I
> have renamed the base64 functions with pg_base64_ as prefix in encode.c,
> to avoid any conflicts in encode.c. pgp-armor.c also gets the same
> treatment. There is no real point in renaming the other functions is
> not necessary, and hex_encode/hex_decode are publicly available, so
> renaming them would cause breakage for any callers of them in plugins.
Pushed.
> It is a bit sad that both pgcrypto and encode.c hold copies of base64
> functions.
And on top of that, there's src/common/base64.c with again almost the
same functionality. But refactoring to fix that would be a bit invasive
and not something to back-patch. I think what you did here is appropriate
as a minimal portability fix. Maybe later somebody will look into
removing the duplication, as a HEAD-only improvement.
regards, tom lane
