Re: pg_do_encoding_conversion glitch - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_do_encoding_conversion glitch
Date
Msg-id 9249.1226372538@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_do_encoding_conversion glitch  (ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
List pgsql-hackers
ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp> writes:
> Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Do you have a proposal for a different API, or do you just want to
>> improve the comment for the function?  Bear in mind that a lot of the
>> callers do know the string length, and so we shouldn't impose an
>> unnecessary strlen() operation on those cases.

> We already have the following comment, so I think a new comment is
> not needed. 
> | In the case of no conversion, src is returned.

I added a few more lines just to help people out --- in digging around
earlier today, there seemed to be a few places that hadn't been very
careful about this.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Patch for ISO-8601-Interval Input and output.
Next
From: ITAGAKI Takahiro
Date:
Subject: Re: autovacuum and reloptions