Re: [PATCH] plpython function causes server panic - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] plpython function causes server panic
Date
Msg-id 920167.1711122660@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] plpython function causes server panic  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Dec 29, 2023 at 12:56 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Here's a draft patch along this line.  Basically the idea is that
>> subtransactions used for error control are now legal in parallel
>> mode (including in parallel workers) so long as they don't try to
>> acquire their own XIDs.  I had to clean up some error handling
>> in xact.c, but really this is a pretty simple patch.

> I agree with the general direction. A few comments:

Thanks for looking at this!  I was hoping you'd review it, because
I thought there was a pretty significant chance that I'd missed some
fundamental reason it couldn't work.  I feel better now about it
being worth pursuing.

I consider the patch draft quality at this point: I didn't spend
much effort on docs or comments, and none on test cases.  I'll
work on those issues and come back with a v2.

            regards, tom lane



pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: documentation structure
Next
From: Tom Lane
Date:
Subject: Re: sublink [exists (select xxx group by grouping sets ())] causes an assertion error