Cast to uint16 in pg_checksum_page() - Mailing list pgsql-hackers

Hackers,

The current code in checksum_impl.h does not play nice with -Wconversion 
on gcc:

warning: conversion to 'uint16 {aka short unsigned int}' from 'uint32 
{aka unsigned int}' may alter its value [-Wconversion]
                                           return (checksum % 65535) + 1;
                                                  ~~~~~~~~~~~~~~~~~~~^~~

It seems like an explicit cast to uint16 would be better?

Regards,
-- 
-David
david@pgmasters.net