Request a Demo
Home   >   mailing lists

Re: Remove unneeded cast in heap_xlog_lock. - Mailing list pgsql-hackers

From Chao Li
Subject Re: Remove unneeded cast in heap_xlog_lock.
Date
Msg-id 91D58D7F-B9A9-42F3-96F4-415A04E9097E@gmail.com
Whole thread Raw
In response to Re: Remove unneeded cast in heap_xlog_lock.  (Kirill Reshke <reshkekirill@gmail.com>)
List pgsql-hackers
Tree view


On Aug 22, 2025, at 13:36, Kirill Reshke <reshkekirill@gmail.com> wrote:


I do not insist on this modification. I just spotted two completely
same codes in [0] & [1], which only differ in BufferGetPage cast. And
I merely tried to do something with it.

v2 attached with all 69 casts removed, but I see there is a little
chance of this committed.

[0] https://github.com/postgres/postgres/blob/13b935c/src/backend/access/heap/heapam_xlog.c#L1007-L1050
[1] https://github.com/postgres/postgres/blob/13b935c/src/backend/access/heap/heapam_xlog.c#L1083-L1121

--
Best regards,
Kirill Reshke
<v2-0001-Remove-unneeded-cast-in-BufferGetPage.patch>

As there are only 76 occurrences, I think using one commit to clean up the unnecessary cast is worthwhile.

--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/




pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: misleading error message in ProcessUtilitySlow T_CreateStatsStmt
Next
From: Dilip Kumar
Date:
Subject: Potential problem in commit f777d773878 and 4f7f7b03758