Re: Inconsistent RestrictInfo serial numbers - Mailing list pgsql-hackers

From Andrei Lepikhov
Subject Re: Inconsistent RestrictInfo serial numbers
Date
Msg-id 9173c9e2-1af5-471c-88f0-73fad4805f07@gmail.com
Whole thread Raw
Responses Re: Inconsistent RestrictInfo serial numbers
List pgsql-hackers
On 10/8/24 18:20, Richard Guo wrote:
> To fix, I think we can reset the root->last_rinfo_serial counter after
> generating the additional constant-FALSE RestrictInfo.  Please see
> attached.
Thanks for the job!
The approach will work, no doubt. But why are you using such a wordy 
approach with save_last_rinfo_serial? I'd say it is better to invent a 
function like make_rinfo_variant() or something like that and explicitly 
set rinfo_serial. It will be easier to read and understand in the 
future, won't it?

-- 
regards, Andrei Lepikhov




pgsql-hackers by date:

Previous
From: Yugo Nagata
Date:
Subject: Re: Set AUTOCOMMIT to on in script output by pg_dump
Next
From: shveta malik
Date:
Subject: Re: Conflict Detection and Resolution